Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 421: Fix Sphinx reference warnings #4150

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 3, 2024

For #4087.

#dino_viehland_2009 and #jython were added in 99d6530 but never referenced.

#tag_impl and #tests were added in b5d1d94 but never referenced.


📚 Documentation preview 📚: https://pep-previews--4150.org.readthedocs.build/

@ericsnowcurrently
Copy link
Member

I'm fine with removing the unused references, but ideally we could keep the information on the PEP in some form.

@hugovk
Copy link
Member Author

hugovk commented Dec 6, 2024

I'll change them to regular bullet points.

@hugovk
Copy link
Member Author

hugovk commented Dec 6, 2024

How's this?

b03a50a

https://pep-previews--4150.org.readthedocs.build/pep-0421/#references

@ericsnowcurrently
Copy link
Member

Fine with me. Thanks for taking the time!

@hugovk hugovk merged commit f91366e into python:main Dec 6, 2024
5 checks passed
@hugovk hugovk deleted the pep421-fix-sphinx-warning branch December 6, 2024 18:17
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants