Skip to content

PEP 753: Mark as Accepted #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

woodruffw
Copy link
Contributor

@woodruffw woodruffw commented Oct 10, 2024

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw requested a review from warsaw as a code owner October 10, 2024 16:14
@AA-Turner AA-Turner changed the title PEP 753: mark as accepted PEP 753: Mark as Accepted Oct 10, 2024
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!

A

@AA-Turner
Copy link
Member

AA-Turner commented Oct 10, 2024

CI failing due to #4044

Edit: @woodruffw I can't use the "update branch" button as this PR is from an organisation (@woodruffw-forks), but if you merge in #4044 then CI should pass.

woodruffw and others added 2 commits October 10, 2024 18:03
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@woodruffw
Copy link
Contributor Author

Edit: @woodruffw I can't use the "update branch" button as this PR is from an organisation (@woodruffw-forks), but if you merge in #4044 then CI should pass.

Whoops, sorry about that. Updated!

@AA-Turner AA-Turner enabled auto-merge (squash) October 10, 2024 17:04
@AA-Turner AA-Turner merged commit 0057f88 into python:main Oct 10, 2024
5 checks passed
@woodruffw woodruffw deleted the ww/accept-753 branch October 10, 2024 21:42
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
Signed-off-by: William Woodruff <william@yossarian.net>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants