Skip to content

Conversation

@AA-Turner
Copy link
Member

No description provided.

@AA-Turner
Copy link
Member Author

@AA-Turner AA-Turner merged commit 8d3c3fd into main Jan 6, 2023
@AA-Turner AA-Turner deleted the AA-Turner-patch-1 branch January 6, 2023 16:50
@CAM-Gerlach
Copy link
Member

To clarify for others, this is in reference to images not being copied on the CIs when Sphinx was upgraded from 6.0.0 -> 6.1.1 between jobs, as first discovered on #2949 and documented in #2949 (comment) .

The specific version causing the change appears to be 6.1.0; 6.0.1 copies the images https://github.com/CAM-Gerlach/peps/actions/runs/3857659590/jobs/6575295318 whereas 6.1.0 does not https://github.com/CAM-Gerlach/peps/actions/runs/3857683684/jobs/6575346593 with all else held constant.

However, I cannot reproduce the issue locally on my Windows machine to be able to git bisect even with identical versions of everything, and my Linux boxes/VMs don't have a recent enough Python version installed by default. As @hugovk can repro it on his Mac, it seems to be a *nix-specific issue.

@hugovk
Copy link
Member

hugovk commented Jan 6, 2023

b32841e153431ec02de31e9ec32e79ab3ac7d1c2 is the first bad commit
commit b32841e153431ec02de31e9ec32e79ab3ac7d1c2
Author: Adam Turner <9087854+aa-turner@users.noreply.github.com>
Date:   Mon Jan 2 15:02:33 2023 +0000

    Move tasks into parallel writing

 sphinx/builders/html/__init__.py | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

sphinx-doc/sphinx@b32841e

@AA-Turner
Copy link
Member Author

sphinx-doc/sphinx#11100 has an attempt at a fix.

A

@hugovk
Copy link
Member

hugovk commented Jan 7, 2023

sphinx-doc/sphinx#11100 fixes it locally for me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants