Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 458: Clarify sequence of PyPI and pip integration #2789

Merged
merged 2 commits into from
Oct 22, 2022

Conversation

brainwane
Copy link
Contributor

OK'd by coauthors in Discourse conversation.

@brainwane brainwane requested a review from a team as a code owner September 9, 2022 18:34
@hugovk
Copy link
Member

hugovk commented Sep 13, 2022

This PEP is commented out of the CODEOWNERS file:

# pep-0458.txt, pep-0458-1.png

Probably because the PEP predates the CODEOWNERS file.

PEP 1 says:

Update .github/CODEOWNERS such that any co-author(s) or sponsors with write access to the PEP repository are listed for your new file. This ensures any future pull requests changing the file will be assigned to them.

Shall we add the sponsor, @ncoghlan, to CODEOWNERS for this PEP?

@CAM-Gerlach
Copy link
Member

That would be SOP, but up to @ncoghlan if he still wants to be sponsor, or maybe better to have @dstufft , the PDP-Delegate, be sponsor instead since he's more active nowadays with regard to PyPI, AFAIK.

@hugovk
Copy link
Member

hugovk commented Oct 22, 2022

We can update CODEOWNERS as and when, let's get this merged. Thanks!

@hugovk hugovk merged commit 1838f20 into python:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants