Infra: gitignore generated /topic and wipe via make clean#2683
Merged
CAM-Gerlach merged 1 commit intopython:mainfrom Jul 10, 2022
Merged
Infra: gitignore generated /topic and wipe via make clean#2683CAM-Gerlach merged 1 commit intopython:mainfrom
/topic and wipe via make clean#2683CAM-Gerlach merged 1 commit intopython:mainfrom
Conversation
CAM-Gerlach
approved these changes
Jun 29, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
For the record, IMO the general approach @pradyunsg proposed, checking in actual topic index pages to the source and using a custom pep-table directive to generate all the tabs would be a more sustainable long-term solution than adding our own custom reST source file generation and somewhat hackily getting Sphinx to recognize them, but may as well do this for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2659.