Skip to content

PEP 572: Typo, parenthesize -> parentheses #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
Feb 28, 2022
Merged

PEP 572: Typo, parenthesize -> parentheses #2370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pep-0572.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ The less confusing option is to make ``:=`` bind more tightly than comma.
Always requiring parentheses
----------------------------

It's been proposed to just always require parenthesize around an
It's been proposed to just always require parentheses around an
Copy link
Contributor Author

@eforgacs eforgacs Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestions! Since this pull request just got merged, I'll make a separate pull request for these changes.

Copy link
Member

@JelleZijlstra JelleZijlstra Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can skip these changes, since the existing text is suboptimal but not wrong. We should mostly avoid changes to finalized PEPs.

Copy link
Member

@JelleZijlstra JelleZijlstra Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It's" can also be a contraction for "it has" (e.g., https://en.wiktionary.org/wiki/it%27s#Etymology_1, https://www.grammarly.com/blog/its-vs-its/#:~:text=It's%20is%20a%20contraction%20of,to%20or%20refers%20to%20something.).

Copy link
Contributor

@Rosuav Rosuav Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current "It's" text is fine. It's just the parenthesis/parenthesize that is unambiguously wrong.

assignment expression. This would resolve many ambiguities, and
indeed parentheses will frequently be needed to extract the desired
subexpression. But in the following cases the extra parentheses feel
Expand Down