-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 683: Add a PEP for immortal objects #2320
Merged
ericsnowcurrently
merged 34 commits into
python:main
from
ericsnowcurrently:immortal-objects
Feb 15, 2022
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
b396af6
Add a PEP for immortal objects.
ericsnowcurrently 19991dc
Move the mention of the python-dev thread.
ericsnowcurrently 49a78f0
Add some open questions.
ericsnowcurrently 4241d1b
Py_SETREF() -> Py_SET_REFCNT().
ericsnowcurrently 56e7174
Update the documentation section.
ericsnowcurrently 9589df7
Update the PEP header.
ericsnowcurrently 0cbd50b
Fold "Proposal" into "Specification".
ericsnowcurrently 413f465
Update the "Performance" section.
ericsnowcurrently 4099282
Drop unused sections.
ericsnowcurrently 02260bf
Fix typos.
ericsnowcurrently 9126cc6
Add an open issue.
ericsnowcurrently 850bd8d
Enumerate objects that will be immortalized.
ericsnowcurrently 57b536c
Update the "Motivation" section.
ericsnowcurrently 7437848
Clarify how we will probably identify immortal objects.
ericsnowcurrently 016f895
Give examples of what are global objects.
ericsnowcurrently 904868d
Assign a PEP number.
ericsnowcurrently a048b57
Update the PEP header.
ericsnowcurrently 7d5401c
Drop the "Concerns" section.
ericsnowcurrently 5340a17
Drop the "How to Teach This" section.
ericsnowcurrently 63caa44
Drop an unnecessary aside.
ericsnowcurrently ab6943e
Add a rejected idea.
ericsnowcurrently 743c753
Update CODEOWNERS.
ericsnowcurrently 92fc5d4
Do not use an inline link for the implementation PR.
ericsnowcurrently 4e1f5fc
Add a link to the docs explaining refcounts.
ericsnowcurrently c94ef99
Drop the PEP delegate.
ericsnowcurrently 4667e82
Don't use footnotes for plain links.
ericsnowcurrently d6a88f3
Update Eddie's email address.
ericsnowcurrently 6816e8f
Change the type.
ericsnowcurrently db4a703
Fix the References section.
ericsnowcurrently 77bd7ee
Mention how Py_SET_REFCNT() won' change the refcount.
ericsnowcurrently f8cf975
Mention that GC state also impacts true immutability for containers.
ericsnowcurrently bb17abb
Emphasize the impact on app scalability.
ericsnowcurrently 6eb4b36
Explain cleanup in the Specification section.
ericsnowcurrently aa5f14e
sys.gettotalrefcount() is not affected.
ericsnowcurrently File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change the type.
- Loading branch information
commit 6816e8f45b91a36ff6bb27e07285c411cd4c3505
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PEP with a link to the actual thread once you create it, so it is easy for others to find without a lot of guessing and Googling.
Also, there are a smattering of relatively non-critical editing issues (aside from the title containing a comma, which is a bit irregular), but as this was merged just as I got to it, I'm a bit late to the party now so if needed, I can make a separate PR fixing those (though they aren't terribly critical).