PEP-654: clarify that BaseExceptionGroup is the factory function that… #2203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… makes auto selection between ExceptionGroup and BaseExceptionGroup
JelleZijlstra
approved these changes
Dec 22, 2021
gvanrossum
reviewed
Dec 22, 2021
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
IMO we should also add that the ExceptionGroup constructor rejects exceptions that are BaseExceptions but not Exceptions.
gvanrossum
approved these changes
Dec 22, 2021
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM. You can take this to the SC (and @warsaw) now.
warsaw
approved these changes
Dec 24, 2021
Member
warsaw
left a comment
warsaw
left a comment
There was a problem hiding this comment.
Awaiting SC approval, but LGTM (with @gvanrossum 's suggestion). Thanks!
Member
|
The (2022) SC approves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… makes auto selection between ExceptionGroup and BaseExceptionGroup