PEP 0554: drop wording about daemon threads in isolated subinterpreters #2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new threads are not allowed (including daemon threads) implies that the opposite is true in isolated=False subinterpreters, that new threads are allowed (*excluding* daemon threads)
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
I can certainly see there's some ambiguity there.
|
|
||
| * importing an extension module fails if it does not implement the | ||
| PEP 489 API | ||
| * new threads are not allowed (including daemon threads) |
Member
There was a problem hiding this comment.
The reminder about daemon threads is worth keeping, I think. How about shifting it around to resolve the clarity problem: "new threads (including daemon threads) are not allowed"?
graingert
commented
Jul 11, 2021
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Member
|
Thanks for the changes, @graingert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new threads are not allowed (including daemon threads) implies that the opposite
is true in isolated=False subinterpreters: that new threads are allowed (excluding daemon threads)