Skip to content

PEP 517: Fix odd url markup #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mariatta merged 1 commit into from
Jun 17, 2021
Merged

PEP 517: Fix odd url markup #1992

Mariatta merged 1 commit into from
Jun 17, 2021

Conversation

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Jun 17, 2021

It currently looks kinda odd.

Screen Shot 2021-06-17 at 11 32 29 AM

Though I'm not sure of the original intention. Which part does the author want to be linked?

@Mariatta Mariatta requested a review from njsmith as a code owner June 17, 2021 18:33
@AA-Turner
Copy link
Member

AA-Turner commented Jun 17, 2021 •
edited
Loading

Would this also be fixed by removing the space between the s and the first grave accent? That would make a grad student's render in italic and then $PYTHONSTARTUP render as code.

With your current change I think the grave accent on line 868 should also be removed (before a), as else you have an unclosed start of an italic passage.

@AA-Turner
Copy link
Member

AA-Turner commented Jun 17, 2021 •
edited
Loading

Built locally after removing the space between the s and the first grave accent and can confirm it renders as I hypothesised above.

ignore this, realised not actually meant to be in italics. sorry!

@Mariatta Mariatta merged commit 82cd151 into master Jun 17, 2021
@Mariatta Mariatta deleted the Mariatta-patch-2 branch June 17, 2021 22:49
@Mariatta
Copy link
Member Author

Mariatta commented Jun 17, 2021

Thanks for the reviews.

@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njsmith njsmith njsmith approved these changes

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mariatta @AA-Turner @njsmith @the-knights-who-say-ni