Convert 10 text PEPs to reST format #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 208 PEP 272: - Fix example traceback code from File "<stdin>", line 1, in ? into File "<stdin>", line 1, in <module> PEP 273: - replace urls from http://python.org/sf/* into https://bugs.python.org/issue* PEP 292 PEP320: - move urls into references section - replace urls from http://python.org/sf/* into https://bugs.python.org/issue* PEP 330 PEP 331: - fix PSF contributor agreement url - replace urls from http://python.org/sf/* into https://bugs.python.org/issue* PEP 357 PEP 3130 PEP 3140
|
LGTM |
berkerpeksag
reviewed
Feb 3, 2017
|
|
||
| >>> import DES | ||
| >>> obj = DES.new('abcdefgh', DES.MODE_ECB) | ||
| >>> plaintext = "Guido van Rossum is a space alien." | ||
| >>> len(plaintext) | ||
| 34 | ||
| >>> obj.encrypt(plaintext) | ||
| Traceback (innermost last): | ||
| File "<stdin>", line 1, in ? | ||
| Traceback (innermost last):: |
There was a problem hiding this comment.
This is a traceback so the additional : is not needed.
| Traceback (innermost last): | ||
| File "<stdin>", line 1, in ? | ||
| Traceback (innermost last):: | ||
| File "<stdin>", line 1, in <module> |
There was a problem hiding this comment.
Two spaced indentation looks correct to me.
| Traceback (innermost last): | ||
| File "<stdin>", line 1, in ? | ||
| Traceback (innermost last):: | ||
| File "<stdin>", line 1, in <module> |
There was a problem hiding this comment.
If we want to modernize the traceback, we also need to update Traceback (innermost last):. But I think it's better to keep the old format:
Traceback (innermost last):
File "<stdin>", line 1, in ?
ValueError: Strings for DES must be a multiple of 8 in length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 208
PEP 272:
from
File "<stdin>", line 1, in ?into
File "<stdin>", line 1, in <module>PEP 273:
into https://bugs.python.org/issue*
PEP 292
PEP320:
into https://bugs.python.org/issue*
PEP 330
PEP 331:
into https://bugs.python.org/issue*
PEP 357
PEP 3130
PEP 3140
Continuing work for #4