Conversation
Member
methane
commented
Feb 6, 2021
methane
commented
- Add Backward/Forward Compatibility section
- Add How to teach this section
- Remove io.LOCALE_ENCODING constant
* Add Backward/Forward Compatibility section * Add How to teach this section * Remove io.LOCALE_ENCODING constant
Member
|
I am a core-dev, but not an expert in this domain. The changes proposed looks good to me. |
vstinner
reviewed
Feb 9, 2021
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I like most changes but I'm not sure on how to make the warning quiet (use "locale" on purpose) without losing support for Python 3.9 and older. See my email on python-dev.
Member
|
Thanks, I like the updated PEP ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.