Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: support namespace packages when passing files #9742

Merged
merged 14 commits into from
Dec 12, 2020
Merged

mypy: support namespace packages when passing files #9742

merged 14 commits into from
Dec 12, 2020

Commits on Nov 22, 2020

  1. cosmetic changes to modulefinder 

    Just so that the logic mirrors closely
    hauntsaninja committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    ccb5e94 View commit details
    Browse the repository at this point in the history

  2. better crawling for namespace packages, explicit base dirs, abs paths

    hauntsaninja committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    a5a24c9 View commit details
    Browse the repository at this point in the history

  3. fix package root validation

    hauntsaninja committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    f228956 View commit details
    Browse the repository at this point in the history

  4. fix test failing from absolute path change

    hauntsaninja committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    c3cfef2 View commit details
    Browse the repository at this point in the history

  5. fix build source ordering 

    Apparently this is something mypy is sensitive to. Thanks mypy primer!
    hauntsaninja committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    dec730a View commit details
    Browse the repository at this point in the history

  6. actually inherit from FileSystemCache to appease mypyc 

    This means we could accidentally fallback to calling a FileSystemCache
method if stuff gets moved around.
    hauntsaninja committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    dfaf104 View commit details
    Browse the repository at this point in the history

  7. don't change base dir if module name is invalid 

    mypy_primer points out two undesirable effects:
1) scripts causing search path confusion
2) scripts with the same names causing issues (e.g. migrations in zulip)
    hauntsaninja committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    739f067 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. fix test find sources on windows

    hauntsaninja committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    3a762b0 View commit details
    Browse the repository at this point in the history

  2. make changes to package root logic more minimal

    hauntsaninja committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    6b78138 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. [minor] fix typo

    hauntsaninja committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    c07e26e View commit details
    Browse the repository at this point in the history

  2. add docstring to get_explicit_package_bases

    hauntsaninja committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    bce2e07 View commit details
    Browse the repository at this point in the history

  3. options: document namespace_packages and explicit_package_bases

    hauntsaninja committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    bcdcf06 View commit details
    Browse the repository at this point in the history

  4. [minor] fix style nit

    hauntsaninja committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    73ae65b View commit details
    Browse the repository at this point in the history

  5. test_find_sources: add multiple directory tests

    hauntsaninja committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    d6a5339 View commit details
    Browse the repository at this point in the history