Fix yield from semantics for AnyType #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Basically improvement for #873. Pretty small. Verified test went from failing to passing. |
Revised version of someone else's PR that also should also avoid a crash when the type isn't some sort of Instance. Avoids cast using the now-possible `if not isinstance: return` construction.
|
Thanks for fixing #873! Looks good and you even took advantage of |
JukkaL
added a commit
that referenced
this pull request
Oct 17, 2015
Fix yield from semantics for AnyType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised version of someone else's PR that also should also
avoid a crash when the type isn't some sort of Instance. Avoids
cast using the now-possible
if not isinstanceconstruction.