Inform about no explicit export instead of attribute suggestions

[kamilturek]

Fixes #9084

[bluetech]

This is a helpful improvement.

The message in your first version of the patch is a bit more understandable than the second IMO (the "Append to message instead of overwriting" commit). Interested why you changed it.

[kamilturek]

This is a helpful improvement.

The message in your first version of the patch is a bit more understandable than the second IMO (the "Append to message instead of overwriting" commit). Interested why you changed it.

I didn't want to so radically change the message, but I may bring it back as it is more understable.

[bluetech]

Yes, I can see this.

Perhaps the right thing to do it give it an entirely new error code, like attr-exported, instead of attr-defined. Not sure what is the policy regarding the granularity of these though.

[JukkaL]

Not sure what is the policy regarding the granularity of these though.

The policy on error codes is that if there's a realistic use case where having a separate error code would help, or if some error message can be confusing and providing more context via an error code (which can be looked up from the docs) can be helpful, splitting an error code may be reasonable.

[JukkaL]

Thanks for the improving the error message! The original error messages was quite confusing. Looks good.

By the way, I also kind of like the message in the first commit. Feel free to change it back if you like. (Or maybe also add " (implicit reexport disabled)" to the end to make this even clearer?)

[kamilturek]

I have changed back the message and appended "implicit reexport disabled".

[hauntsaninja]

Thanks!