Allow type aliases in runtime context #8779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this! Now inferred types of runtime types are inconsistent, however: from typing import Union
A = Union[int, str]
reveal_type(A) # object
reveal_type(Union[int, str]) # AnyCan you also update the type of |
|
@JukkaL opened python/typeshed#3966 for this. |
ilevkivskyi
added a commit
to python/typeshed
that referenced
this pull request
May 5, 2020
This is an accompanying PR for python/mypy#8779, see python/mypy#8779 (comment) I also noticed that Python 2 and Python 3 versions are a bit out of sync, so I also put them back in sync.
|
Thank you! |
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
This is an accompanying PR for python/mypy#8779, see python/mypy#8779 (comment) I also noticed that Python 2 and Python 3 versions are a bit out of sync, so I also put them back in sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5354
This PR allows using type aliases in runtime context and instead gives the an
objecttype (which is the best type that we know). The new error messages are less specific, but the old logic caused annoying false positives for various ORMs that use non-annotation syntax, and for runtime type validation tools.While working on this I found a minor bug in
object_or_any_from_type()that returnedAnyforUnion[int, Any]while it should beobject.