Modified expand_path in config_parser to add environment var for mypy_path #8574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
reviewed
Mar 23, 2020
|
@blueyed , I am not able to re-request review here. Please review. |
ilevkivskyi
reviewed
Mar 27, 2020
|
@ilevkivskyi , please review. |
|
TBH, I don't totally understand the logic/reasoning behind this so I will leave it to someone else to review. |
|
cc @JukkaL |
|
Closing, since we merged #9414 to address the same issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes #7967 and #7968 .
@JukkaL, @ethanhs and @blueyed , Please review this PR.