Infer type for partial generic type from assignment #8036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code like this no longer requires a type annotation:
```
a = []
if foo():
a = [1]
```
ilevkivskyi
approved these changes
Nov 29, 2019
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks! Just one comment, I think case of self.x is important.
| if foo(): | ||
| x = [1] # Infer List[int] as type of 'x' | ||
| """ | ||
| if (isinstance(lvalue, NameExpr) |
Member
There was a problem hiding this comment.
Should this actually be a NameExpr or RefExpr is fine? I am thinking about self.x = [], please add tests if yes.
Collaborator
Author
There was a problem hiding this comment.
Partial types are not properly supported with attributes in general, so this is consistent with how things work elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code like this no longer requires a type annotation:
Work towards #1055.