Remove mypy.messages from the typeops tangle #7400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy.applytype needs to be able to report errors, so have it take an error reporting callback.
gvanrossum
approved these changes
Aug 27, 2019
ilevkivskyi
reviewed
Aug 28, 2019
| context=target) | ||
| if msg.is_errors(): |
There was a problem hiding this comment.
This pattern is unfortunately used quite often in other contexts (in particular in overloads, see #7367). It would be great to get rid of those (but in case of methods I would probably prefer self.flag rather that nonlocal).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy.applytype needs to be able to report errors, so have it
take an error reporting callback.