Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error code arguments to plugin API #7323

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Add error code arguments to plugin API #7323

merged 3 commits into from
Aug 12, 2019

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Aug 12, 2019

Update some fail() methods to accept an error code argument.

ilevkivskyi
ilevkivskyi approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Do we need a test case for how this is used in a plugin?

@JukkaL
Copy link
Collaborator Author

JukkaL commented Aug 12, 2019

Do we need a test case for how this is used in a plugin?

This would be nice, but I don't think that it's urgent. I'll create a follow-up issue.

@JukkaL JukkaL merged commit 6e75f9d into master Aug 12, 2019
@JukkaL JukkaL mentioned this pull request Aug 12, 2019
Open
@JelleZijlstra JelleZijlstra deleted the errcode-fail-arg branch August 12, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JukkaL @ilevkivskyi