Basic support for typing_extensions.Annotated. #7292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Aug 6, 2019
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
Thanks! This looks great. We'll need to package up the expressions into a RawExpressionType like discussed in the issue before this is likely to be truly useful to things that actually want to use Annotated, but accepting it is an important first step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7021. This adds basic support for
typing_extensions.Annotated. Currently, we just discard all annotations and resolve to the inner type.Plugins can use
get_type_analyze_hookto try to intervene before this step, but most of the arguments that aren't just names orLiteral-able values will have already been mangled by this point. Nothing other than the type sees any sort of validation, either. See the issue discussion for more on this.