New analyser: Fix crash in plugins when star import blocks adding a symbol #7136
Conversation
| # Note that missing names are per module, _not_ per namespace. This means that e.g. | ||
| # a missing name at global scope will block adding same name at a class scope. | ||
| # This should not affect correctness and is purely a performance issue, | ||
| # since it can cause unnecessary deferrals. |
There was a problem hiding this comment.
Also document * in missing_names. Actually, I'm not sure if anything other than * needs to be supported here, since otherwise we should just be able to add a placeholder. If that's the case, this could be replaced with a boolean flag. (If this is feasible, this change should be made in a separate PR.)
There was a problem hiding this comment.
It is hard to tell how easy it is. I can try it after landing this.
| C() # E: Too few arguments for "C" | ||
| C('no') # E: Argument 1 to "C" has incompatible type "str"; expected "int" | ||
| [file other.py] | ||
| import lib |
There was a problem hiding this comment.
It looks like in this case it should be possible to process the star import without a deferral. Maybe create an issue about this if you agree with that, and add a comment here.
| import lib | ||
| [file lib.py] | ||
| from dataclasses import dataclass | ||
| from other import * |
There was a problem hiding this comment.
Similar to above, maybe we should be able to process this import without adding anything to missing_names.
There was a problem hiding this comment.
Opened #7141 for these two.
| if info[attr.name].type is None and not ctx.api.final_iteration: | ||
| node = info.get(attr.name) | ||
| if node is None: | ||
| return |
There was a problem hiding this comment.
Add comment. Discuss why we don't defer here.
Fixes #7076
The fix is pretty straightforward. I also add a comment about
missing_namesbeing per-module, not per namespace.