New semantic analyzer: fix crash related to dataclasses.InitVar #6984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously InitVar attributes were missing on the second semantic analysis pass, since the dataclasses plugin removes those attributes from the class symbol table. This caused a crash. The fix is to reset the attribute declarations so that they will be re-added to the symbol table on successive semantic analysis passes. Fixes #6955.
ilevkivskyi
approved these changes
Jun 13, 2019
| @@ -520,6 +520,26 @@ app.database_name # E: "SpecializedApplication" has no attribute "database_name | |||
|
|
|||
| [builtins fixtures/list.pyi] | |||
|
|
|||
| [case testDataclassesInitVarsAndDefer] | |||
| # flags: --new-semantic-analyzer | |||
There was a problem hiding this comment.
Is this actually needed? Or it doesn't work well with the old analyzer?
There was a problem hiding this comment.
No, but I added it since the test case doesn't test anything useful on the old analyzer and I didn't want to add it to check-newsemanal.test. We may want to move test cases out of check-newsemanal.test to other files once we've removed the old semantic analyzer, and this is anticipating that move.
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
…on#6984) Previously InitVar attributes were missing on the second semantic analysis pass, since the dataclasses plugin removes those attributes from the class symbol table. This caused a crash. The fix is to reset the attribute declarations so that they will be re-added to the symbol table on successive semantic analysis passes. Fixes python#6955.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously InitVar attributes were missing on the second semantic
analysis pass, since the dataclasses plugin removes those attributes
from the class symbol table. This caused a crash. The fix is to reset
the attribute declarations so that they will be re-added to the symbol
table on successive semantic analysis passes.
Fixes #6955.