Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip error if attribute or method is private to class #6790

Merged
merged 2 commits into from
May 7, 2019
Merged

Skip error if attribute or method is private to class #6790

merged 2 commits into from
May 7, 2019

Conversation

rafaelcaricio
Copy link
Contributor

Fixes #523

ilevkivskyi
ilevkivskyi reviewed May 7, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! As discussed off-line please add the same for multiple inheritance.

ilevkivskyi
ilevkivskyi approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this is ready to be merged when tests pass in CI.

@rafaelcaricio
Copy link
Contributor Author

Thank you for the review @ilevkivskyi !

@ilevkivskyi ilevkivskyi merged commit 34993eb into python:master May 7, 2019
@rafaelcaricio rafaelcaricio deleted the name_mangling_ignore_methods branch May 7, 2019 19:04
@mthuurne mthuurne mentioned this pull request Mar 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double underscore name mangling in classes to allow independent types
2 participants
@rafaelcaricio @ilevkivskyi