New semantic analyzer: generalize placeholders to all symbol nodes #6336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't still do anything useful with the node.
The use of 'missing_names' will prevent an invalid placeholder from being created.
ilevkivskyi
approved these changes
Feb 5, 2019
| if self.is_alias_for_final_name(lval.name): | ||
| if lvalue.node: | ||
| # This has been bound already in a previous iteration. | ||
| return |
There was a problem hiding this comment.
Why do we do this for names but not for attributes? Maybe leave a comment/TODO about this.
There was a problem hiding this comment.
I'll create an issue about dealing with attribute definitions (through self.x).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the concept of placeholder nodes to also cover
assignment statements and imports. Previously they were only
created for class definitions. The main motivation is to prevent
access to definitions in outer namespaces if there is an
incomplete definition that should take precedence.
Fixes #6299.
This also does a few other updates:
generate an error instead of producing placeholder nodes. This
allows the analysis to terminate in certain cases of import
cycles at least.
analyze_name_lvalue. The motivation isthat some early experiments made the old structure unwieldy,
but the refactoring may not be as important for the final design.
This seems like a code quality improvement so I'm including it
here.
rebind it. I'd like to gradually move to this approach more
generally.
any more. I think that these worked by accident. Now these
generally generate "cannot determine type" errors.
more, since placeholders count as definitions in this context.
Star imports still generate incomplete namespaces.