Rename variable, OSError.filename will have union type (typeshed #1852) #4541
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on#1852) The 'path' variable is inferred to have str type, but OSError.filename really is Union[str, bytes, None], which causes a Mypy error.
|
I don't think this is the right thing to do. Unions are terrible from a gradual typing perspective. Your best bet may be to change the attribute in typeshed to |
intgr
added a commit
to intgr/typeshed
that referenced
this pull request
Feb 5, 2018
ambv
pushed a commit
to python/typeshed
that referenced
this pull request
Feb 14, 2018
Starting with Python 3.3, IOError, EnvironmentError and WindowsError are aliases for OSError, which has all the attributes. Reference: * https://docs.python.org/3/library/exceptions.html#OSError * https://www.python.org/dev/peps/pep-3151/ * OSError: Drop Python <3.3 compatibility * Use Any instead of Union for filename/filename2 type, per GvR comment See: python/mypy#4541
|
Merged in Typeshed; this is now unnecessary, closing. python/typeshed#1852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/typeshed#1852, I want to change the type of
OSError.filenametoUnion[str, bytes, None], but since thepathvariable is inferred to havestrtype, this causes a Mypy error.On the other hand, the
path = error.filenameassignment seems of questionable value anyway, sincepathalready contained the path. But I may be missing something so I erred on the side of caution of not (potentially) changing the behavior.