disallow generic Enums and fix assigning Enum indexes #3140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is the correct fix. I just would add one more test to check that |
ilevkivskyi
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3137
Under some circumstances, Enum indexing was interpreted as creating a type alias. I fixed that bug by making it so that indexing an Enum typeinfo never creates an alias. Not the most elegant solution but I'm not sure there's a better one.
In the process, I discovered that mypy allows generic enums. I don't think a generic enum makes practical sense, and inheriting from both
EnumandGeneric[T]fails at runtime with a metaclass conflict. Therefore, this PR also disallows generic enums.