Add git commit hash to version when not building wheel #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Mar 14, 2017
setup.py
Outdated
| from mypy import git | ||
|
|
||
| git.verify_git_integrity_or_abort(".") | ||
|
|
||
| version = base_version | ||
| if 'bdist_wheel' in sys.argv[1:]: |
There was a problem hiding this comment.
We'll need a similar exception for 'sdist'. See the misc/upload-pypy.py script, it runs python3 setup.py bdist_wheel and python3 setup.py sdist.
Otherwise this seems to work and solves my problem, so thanks!
pkch
force-pushed
the
feature-versioning
branch
from
451f197
to
fff9093
Compare
|
Oh I am on Windows, so I forgot that source distribution is a thing =) |
|
LGTM. Will merge when tests pass. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2547
This detects whether we're building a wheel by searching for
bdist_wheelamong command-line arguments to setup.py. If it's not a wheel, then the full version (with git commit hash if available) is used.