Don't check method subtyping when supertype method's type is Any
#2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes a crash I encountered in the semanalysis phase when I used @ddfisher 's repro in a test without the right builtin shim. By "fixes" I mean "still crashes, but now with a message that tells you what is going on" |
Previously, we were bailing out with an error because we thought that overriding a non-method type with a method type was bad. This comes up when you have an untyped decorator on a supertype method. python#2782
sixolet
force-pushed
the
subtype-of-any-method
branch
from
80c47a1
to
ada19e5
Compare
|
Belay that last comment, it was causing trouble so I removed it. |
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were bailing out with an error because we thought that overriding
a non-method type with a method type was bad.
This comes up when you have an untyped decorator on a supertype method.
#2782