Add support for __init_subclass__
#2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
changed the title
__Init_subclass____init_subclass__
|
I think it should be subsumed by #2475, or merged afterwards. |
|
I haven't reviewed your patch in detail, but I think the functionality implemented by this patch is pretty independent from metaclass support. There's some more work possible to typecheck class definitions with |
gvanrossum
approved these changes
Jan 9, 2017
| @@ -108,9 +108,9 @@ reveal_type(B.new()) # E: Revealed type is '__main__.B*' | |||
|
|
|||
| [case testSelfTypeOverride] | |||
| from typing import TypeVar, cast | |||
|
|
|||
There was a problem hiding this comment.
Next time you submit a PR, can you instruct your editor not to clean up trailing whitespace on lines you otherwise didn't touch? While it looks better, the many trivial chunks in the diff are distracting during a review.
|
Thanks! |
gvanrossum
pushed a commit
to python/typeshed
that referenced
this pull request
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.6 added the new
_init_subclass__magic method, which requires special support because its first argument is notself(similar to__new__).I submitted a separate pull request to typeshed (python/typeshed#813) to add the new method to stubs.