Skip to content

Revert a perf optimization for deferred nodes #20894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 1 commit into from
Feb 25, 2026
Merged

Revert a perf optimization for deferred nodes #20894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3152,13 +3152,6 @@ def visit_block(self, b: Block) -> None:
self.binder.unreachable()
return
for s in b.body:
# If we export types, we need to continue checking to make sure all
# expressions are present in type map (even if most have type Any).
if self.current_node_deferred and not self.options.export_types:
# With current deferral logic there is no point continuing to
# type-check current function, as we will not infer more types,
# will not show errors, and each expression is inferred as Any.
return
if self.binder.is_unreachable():
if not self.should_report_unreachable_issues():
break
Expand Down Expand Up @@ -4830,7 +4823,6 @@ def check_simple_assignment(
and inferred is not None
and inferred.type is not None
and not inferred.is_final
and not self.current_node_deferred
):
new_inferred = remove_instance_last_known_values(rvalue_type)
# Should we widen the inferred type or the lvalue? Variables defined
Expand Down