Uncomment two tests and xfail them instead, to reduce the chance of code rot#20887
Open
wyattscarpenter wants to merge 1 commit intopython:masterfrom
Open
Uncomment two tests and xfail them instead, to reduce the chance of code rot#20887wyattscarpenter wants to merge 1 commit intopython:masterfrom
wyattscarpenter wants to merge 1 commit intopython:masterfrom
Conversation
…ode rot. These had already broken as fixtures are pyi files and not py files, now.
Member
|
We might still get PEP 718, I guess. Do we get any value out of keeping this xfailed test around? |
Member
|
Oh wow, I somehow completely missed this PEP, I think this is great idea. IMO it is more pythonic to have x = foo[int](...)than for local variables. (I mean there is no such thing as a local variable in Python, there are just names). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These had already broken slightly as fixtures are pyi files and not py files, now. I also fixed that.
This is a sort of curious change, as these used to be
-skipped, anyway, before the previous commit commented them out.