Skip to content

Uncomment two tests and xfail them instead, to reduce the chance of code rot#20887

Open
wyattscarpenter wants to merge 1 commit intopython:masterfrom
wyattscarpenter:typeapptests
Open

Uncomment two tests and xfail them instead, to reduce the chance of code rot#20887
wyattscarpenter wants to merge 1 commit intopython:masterfrom
wyattscarpenter:typeapptests

Conversation

@wyattscarpenter
Copy link
Contributor

These had already broken slightly as fixtures are pyi files and not py files, now. I also fixed that.

This is a sort of curious change, as these used to be -skipped, anyway, before the previous commit commented them out.

…ode rot.

These had already broken as fixtures are pyi files and not py files, now.
@JelleZijlstra
Copy link
Member

We might still get PEP 718, I guess. Do we get any value out of keeping this xfailed test around?

@ilevkivskyi
Copy link
Member

Oh wow, I somehow completely missed this PEP, I think this is great idea. IMO it is more pythonic to have

x = foo[int](...)

than

x: some_type[int] = foo(...)

for local variables. (I mean there is no such thing as a local variable in Python, there are just names).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants