Fix crash on PlaceholderNode serialization and add regression test (GH-20796)#20876
Closed
Kaushalt2004 wants to merge 1 commit intopython:masterfrom
Closed
Fix crash on PlaceholderNode serialization and add regression test (GH-20796)#20876Kaushalt2004 wants to merge 1 commit intopython:masterfrom
Kaushalt2004 wants to merge 1 commit intopython:masterfrom
Conversation
Member
|
I think you have pushed a wrong commit. Content of he PR doesn't match the description. |
Contributor
Author
Yes sorry there was a confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in mypy that occurred when encountering a PlaceholderNode during cache serialization, such as with invalid starred assignment syntax (*a = b). Instead of raising a NotImplementedError and crashing, mypy now logs a user-friendly error and skips cache writing for the problematic module.