Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mypy/meet.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,15 @@ def narrow_declared_type(declared: Type, narrowed: Type) -> Type:
):
return original_declared
return meet_types(original_declared, original_narrowed)
elif (
isinstance(declared, CallableType)
and isinstance(narrowed, CallableType)
and has_type_vars(declared.ret_type)
):
return narrowed.copy_modified(
ret_type=narrow_declared_type(declared.ret_type, narrowed.ret_type)
)

return original_narrowed


Expand Down
23 changes: 23 additions & 0 deletions test-data/unit/check-narrowing.test
Original file line number Diff line number Diff line change
Expand Up @@ -3826,3 +3826,26 @@ def get_owner(uid: UserId, tid: TeamId):
reveal_type(INVALID) # N: Revealed type is "builtins.int"
return None
[builtins fixtures/primitives.pyi]

[case testNarrowCallableTypeVarByEquality]
from typing import Callable, TypeVar

T = TypeVar("T")

def remove(path: str) -> None: ...
def unlink(path: str) -> None: ...

def f1(func: Callable[..., T], arg: str) -> T:
if func == remove:
reveal_type(func) # N: Revealed type is "def (path: builtins.str) -> T`-1"
reveal_type(func(arg)) # N: Revealed type is "T`-1"
return func(arg)
return func(arg)

def f2(func: Callable[..., T], arg: str) -> T:
if func in [unlink, remove]:
reveal_type(func) # N: Revealed type is "def (path: builtins.str) -> T`-1"
reveal_type(func(arg)) # N: Revealed type is "T`-1"
return func(arg)
return func(arg)
[builtins fixtures/primitives.pyi]