Update arguments to parameters (Additional) [1]

[hyperkai]

Fix: #20683

I changed arguments to parameters in the error messages of these constants below and I also changed some names of constants:

ARGUMENT_TYPE_EXPECTED       => PARAM_TYPE_EXPECTED
MISSING_OR_INVALID_SELF_TYPE
ELLIPSIS_WITH_OTHER_TYPEARGS => ELLIPSIS_WITH_OTHER_TYPEPARAMS
TYPE_SIGNATURE_TOO_MANY_ARGS => TYPE_SIGNATURE_TOO_MANY_PARAMS
TYPE_SIGNATURE_TOO_FEW_ARGS  => TYPE_SIGNATURE_TOO_FEW_PARAMS

[hyperkai]

I also changed Self to self which is actually used as a parameter because It's more understandable:

class Cls:  # ↓↓↓↓
   def method(self) -> None: ...

[JukkaL]

It would be more consistent to use "self" parameter ... if using the lower-case version. I'd prefer it it was either quoted this way (we use double quotes) or unchanged from original, with capitalized 'Self'.

[JukkaL]

Thanks, this makes the terminology more consistent. Mostly looks good.

[JukkaL]

It would be more consistent to use "self" parameter ... if using the lower-case version. I'd prefer it it was either quoted this way (we use double quotes) or unchanged from original, with capitalized 'Self'.

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

colour (https://github.com/colour-science/colour)
- colour/characterisation/aces_it.py:975: error: Ellipses cannot accompany other argument types in function type signature  [syntax]
+ colour/characterisation/aces_it.py:975: error: Ellipses cannot accompany other parameter types in function type signature  [syntax]

cki-lib (https://gitlab.com/cki-project/cki-lib)
- cki_lib/metrics/server.py:8: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/metrics/server.py:8: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/s3bucket.py:18: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/s3bucket.py:18: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/kcidb/validate.py:49: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/kcidb/validate.py:49: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/kcidb/validate.py:137: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/kcidb/validate.py:137: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/cki_pipeline.py:199: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/cki_pipeline.py:199: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/messagequeue.py:269: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/messagequeue.py:269: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/messagequeue.py:338: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/messagequeue.py:338: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/messagequeue.py:389: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/messagequeue.py:389: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- cki_lib/messagequeue.py:447: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ cki_lib/messagequeue.py:447: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- tests/kcidb/test_checks.py:193: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ tests/kcidb/test_checks.py:193: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- tests/kcidb/test_checks.py:207: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ tests/kcidb/test_checks.py:207: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

steam.py (https://github.com/Gobot1234/steam.py)
- steam/_const.py:73: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/_const.py:73: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- steam/utils.py:167: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/utils.py:167: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- steam/utils.py:173: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/utils.py:173: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- steam/utils.py:221: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/utils.py:221: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- steam/utils.py:227: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ steam/utils.py:227: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

discord.py (https://github.com/Rapptz/discord.py)
- discord/client.py:1887: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
+ discord/client.py:1887: error: "self" parameter missing for a non-static method (or an invalid type for self)  [misc]
- discord/client.py:1897: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
+ discord/client.py:1897: error: "self" parameter missing for a non-static method (or an invalid type for self)  [misc]

pyodide (https://github.com/pyodide/pyodide)
- pyodide-build/pyodide_build/common.py:298: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:298: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/common.py:440: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:440: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/common.py:452: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:452: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/common.py:463: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/common.py:463: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/recipe/skeleton.py:237: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/recipe/skeleton.py:237: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/recipe/skeleton.py:246: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/recipe/skeleton.py:246: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/tests/test_cli_xbuildenv.py:29: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/tests/test_cli_xbuildenv.py:29: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/recipe/builder.py:781: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/recipe/builder.py:781: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:133: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:133: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:161: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/tests/recipe/test_graph_builder.py:161: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- pyodide-build/pyodide_build/tests/test_cli.py:299: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyodide-build/pyodide_build/tests/test_cli.py:299: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

pandera (https://github.com/pandera-dev/pandera)
- tests/pandas/test_model.py:47: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
+ tests/pandas/test_model.py:47: error: "self" parameter missing for a non-static method (or an invalid type for self)  [misc]
- tests/pandas/test_model.py:52: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
+ tests/pandas/test_model.py:52: error: "self" parameter missing for a non-static method (or an invalid type for self)  [misc]

artigraph (https://github.com/artigraph/artigraph)
- src/arti/internal/models.py:146: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ src/arti/internal/models.py:146: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]
- src/arti/internal/models.py:150: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ src/arti/internal/models.py:150: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

pyppeteer (https://github.com/pyppeteer/pyppeteer)
- pyppeteer/launcher.py:222: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
+ pyppeteer/launcher.py:222: error: Function is missing a type annotation for one or more parameters  [no-untyped-def]

[A5rocks]

Thank you! Checking over the list from #20683 excluding anything you changed, I think you could also change UNBOUND_TYPEVAR. (I see that TYPE_GUARD_POS_ARG_REQUIRED is actually already fine.)

[hyperkai]

..., I think you could also change UNBOUND_TYPEVAR. (I see that TYPE_GUARD_POS_ARG_REQUIRED is actually already fine.)

The word argument for UNBOUND_TYPEVAR is suitable so we don't need to change it.

[A5rocks]

Is it? I guess because it says "should receive" instead of just talking about parameters? Alright

(for ref):

T = TypeVar('T')
def f() -> T: pass # E: A function returning TypeVar should receive at least one argument containing the same TypeVar  [type-var]

[hyperkai]

A function returning TypeVar should receive at least one argument containing the same TypeVar

According to my understanding, the original error message above means:

If a function returns TypeVar, the function parameter should receive at least one argument containing the same TypeVar

Actually, the original error message itself is not good? So, should I change it to the new error messge which is simpler and more direct as shown below?:

A function returning TypeVar should have at least one same TypeVar parameter

With T for x:

def f[T](x: T) -> T:
    return x
# No error

Without T for x:

def f[T](x) -> T:
    return x
# error: A function returning TypeVar should have at least one same TypeVar parameter

With no parameters:

from typing import cast

def f[T]() -> T:
    return cast(T, 'Hello')
# error: A function returning TypeVar should have at least one same TypeVar parameter

With T1 for x and T2 for return type:

def f[T1, T2](x: T1) -> T2:
    return x
# error: A function returning TypeVar should have at least one same TypeVar parameter

The general definitions of a parameter and argument:

• A parameter is the variable defined in a function signature to receive an argument.
• An argument is the value passed to a function parameter.

[A5rocks]

IMO

A function returning a TypeVar should have at least one parameter containing that TypeVar

But as we've already established, I'm not so good with the specific terminology here so someone else should check that.

[JukkaL]

Thanks for the updates! Let's merge this now, even if there may be other messages that could be updated -- they can be changed in a follow-up PR.