Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type information from isinstance checks in comprehensions #2000

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Use type information from isinstance checks in comprehensions #2000

merged 1 commit into from
Aug 9, 2016

Conversation

ddfisher
Copy link
Collaborator

@ddfisher ddfisher commented Aug 9, 2016

Fix #1734.

@ddfisher
Copy link
Collaborator Author

ddfisher commented Aug 9, 2016

This fixes 1 error in mypy --strict-optional mypy.

@gvanrossum
Copy link
Member

Might this interfere with #1698 ?

@ddfisher
Copy link
Collaborator Author

ddfisher commented Aug 9, 2016

I don't think it should.

@gvanrossum gvanrossum merged commit e2561a8 into master Aug 9, 2016
@gvanrossum gvanrossum deleted the fix-comprehension-isinstance branch August 9, 2016 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddfisher @gvanrossum