Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up to use pytest for our data-driven tests, and switch testcheck over to it #1944

Merged
merged 15 commits into from
Jul 27, 2016
Merged

Set up to use pytest for our data-driven tests, and switch testcheck over to it #1944

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d9ab6fa
wip pytest for testcheck -- sort of mostly works!
gnprice Jul 26, 2016
e087d81
fix skipping
gnprice Jul 26, 2016
494adb6
fix setup/teardown -- now all seems to work!
gnprice Jul 26, 2016
c22efe2
customize output to be a bit more like myunit
gnprice Jul 26, 2016
186b9d0
take more control of error reporting
gnprice Jul 26, 2016
a030509
print traceback, except on SystemExit
gnprice Jul 26, 2016
0e77a38
wip implement -i as --update-data
gnprice Jul 26, 2016
4b63be6
wip refactor
gnprice Jul 26, 2016
390812b
revert accidentally-committed test change to test data
gnprice Jul 26, 2016
8c051dc
tweaks for polish
gnprice Jul 26, 2016
6b0860b
fix self-check
gnprice Jul 26, 2016
f7b15bd
wire up into runtests
gnprice Jul 26, 2016
53035e3
and update README
gnprice Jul 27, 2016
3ffd2b0
explain type: ignore
gnprice Jul 27, 2016
0cc0f1f
parse pytest test counts in runtests
gnprice Jul 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
print traceback, except on SystemExit
  • Loading branch information
@gnprice
gnprice committed Jul 27, 2016
commit a030509d8cadc318c0fabc77ca12f63c2242534c
12 changes: 11 additions & 1 deletion mypy/test/collect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,14 @@ def reportinfo(self):
return self.obj.file, self.obj.line, self.obj.name

def repr_failure(self, excinfo):
return "data: {}:{}\n{}".format(self.obj.file, self.obj.line, excinfo.exconly())
if excinfo.errisinstance(SystemExit):
# We assume that before doing exit() (which raises SystemExit) we've printed
# enough context about what happened so that a stack trace is not useful.
# In particular, uncaught exceptions during semantic analysis or type checking
# call exit() and they already print out a stack trace.
excrepr = excinfo.exconly()
else:
self.parent._prunetraceback(excinfo)
excrepr = excinfo.getrepr(style='short')

return "data: {}:{}\n{}".format(self.obj.file, self.obj.line, excrepr)