Skip to content

Conversation

chadrik
Copy link
Contributor

@chadrik chadrik commented Apr 27, 2025

This PR dramatically improves the types generated for attributes that are instantiated within an __init__ function from typed arguments.

Here's an example input:

class Person:
    def __init__(self, name: str, age: int) -> None:
        self.name = name
        self.age = age

stubgen used to produce this output:

from _typeshed import Incomplete

class Person:
    name: Incomplete
    age: Incomplete
    def __init__(self, name: str, age: int) -> None: ...

Now it produces this output:

class Person:
    name: str
    age: int
    def __init__(self, name: str, age: int) -> None: ...

Pretty handy!

The key to this change is switching MypyOptions.semantic_analysis_only from True to False.

This comment has been minimized.

@chadrik chadrik force-pushed the stubgen/inferred-attrs branch from 4b456d0 to cdd19f9 Compare April 29, 2025 19:22
@chadrik
Copy link
Contributor Author

chadrik commented Apr 29, 2025

@hamdanal @hauntsaninja @JelleZijlstra I would love a review of this if you can spare the time!

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant