Skip to content

stubgen: infer types for class attributes #18978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chadrik
Copy link
Contributor

@chadrik chadrik commented Apr 27, 2025

This PR dramatically improves the types generated for attributes that are instantiated within an __init__ function from typed arguments.

Here's an example input:

class Person:
    def __init__(self, name: str, age: int) -> None:
        self.name = name
        self.age = age

stubgen used to produce this output:

from _typeshed import Incomplete

class Person:
    name: Incomplete
    age: Incomplete
    def __init__(self, name: str, age: int) -> None: ...

Now it produces this output:

class Person:
    name: str
    age: int
    def __init__(self, name: str, age: int) -> None: ...

Pretty handy!

The key to this change is switching MypyOptions.semantic_analysis_only from True to False.

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant