-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix TypeIs
negative narrowing of union of generics
#18193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix TypeIs
negative narrowing of union of generics
#18193
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
More issues might be closed by this PR: sterliakov/mypy-issues#70 I didn't look deeper, but all four look related enough |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I made some small additions. We have a new hit in starlette, but I think this is correct?
Edit: see also #19320
Diff from mypy_primer, showing the effect of this PR on open source code: pytest (https://github.com/pytest-dev/pytest)
+ testing/test_monkeypatch.py:420: error: Unused "type: ignore" comment [unused-ignore]
starlette (https://github.com/encode/starlette)
+ starlette/middleware/errors.py:178: error: Argument 1 to "run_in_threadpool" has incompatible type "Callable[[Request, Exception], Response | Awaitable[Response]] | Callable[[WebSocket, Exception], Awaitable[None]]"; expected "Callable[[Request, Exception], Response]" [arg-type]
+ starlette/_exception_handler.py:61: error: Argument 1 to "run_in_threadpool" has incompatible type "Callable[[Request, Exception], Response | Awaitable[Response]] | Callable[[WebSocket, Exception], Awaitable[None]]"; expected "Callable[[Request | WebSocket, Exception], Any]" [arg-type]
+ starlette/routing.py:68: error: Incompatible types in assignment (expression has type "Callable[..., Awaitable[Any]] | partial[Coroutine[Any, Any, Awaitable[Response] | Response]]", variable has type "Callable[[Request], Awaitable[Response]]") [assignment]
+ starlette/routing.py:68: error: Too few arguments for "run_in_threadpool" [call-arg]
|
Fixes #18009, fixes #19282, fixes #17181
Modelling the runtime behavior of
isinstance
(which erases generic type arguments) isn't applicable toTypeIs
. This PR adds a flag so that we can skip that logic deep insideconditional_types_with_intersection
.It's a little awkward having to pass a flag down through so many call levels, but I can't think of a better way.