Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy_primer workflow #17987

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Oct 17, 2024

Update the mypy_primer workflow to use actions/upload-artifact@v4.
https://github.com/actions/upload-artifact/tree/v4

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressed you got this working with only two force pushes :-)
Want to make the same PR to typeshed and pyright?

@hauntsaninja hauntsaninja merged commit 123eb91 into python:master Oct 18, 2024
18 checks passed
@cdce8p cdce8p deleted the update-primer-workflow branch October 18, 2024 01:59
@cdce8p
Copy link
Collaborator Author

cdce8p commented Oct 18, 2024

Want to make the same PR to typeshed and pyright?

It looks like both repos are already up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants