Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypyc] fix relative imports in __init__.py #17979

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Oct 17, 2024

Fixes mypyc/mypyc#1070

Missed in #10543

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be good to add a test, if it's easy enough to do it.

@hauntsaninja
Copy link
Collaborator Author

It looks like the existing test testMultiModuleRelative (added in mypyc/mypyc#625) isn't even actually compiled? So will need some test infra changes...

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 21, 2024

Ok, in that case let's merge this as is.

@JukkaL JukkaL merged commit cb9dd7d into python:master Oct 21, 2024
12 checks passed
@hauntsaninja hauntsaninja deleted the mypyc-init branch October 22, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect code generation for relative imports inside __init__.py
2 participants