Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tox to 4.21.2 #17946

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Update tox to 4.21.2 #17946

merged 3 commits into from
Oct 14, 2024

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Oct 14, 2024

This comment has been minimized.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it looks like there's some issue with colour codes on the Windows build. Is it related? I don't see issues on master

@cdce8p
Copy link
Collaborator Author

cdce8p commented Oct 14, 2024

Hm, it looks like there's some issue with colour codes on the Windows build. Is it related? I don't see issues on master

Yeah, saw that too. Looking into it now.

@cdce8p cdce8p marked this pull request as draft October 14, 2024 21:59
@cdce8p cdce8p marked this pull request as ready for review October 14, 2024 22:51
@cdce8p
Copy link
Collaborator Author

cdce8p commented Oct 14, 2024

Hm, it looks like there's some issue with colour codes on the Windows build. Is it related? I don't see issues on master

This is caused by tox-dev/tox#3172. Since version 4.12.0 FORCE_COLOR is now automatically passed to pytest by tox. However, the test diff output color is actually disabled for win32.

mypy/mypy/test/helpers.py

Lines 118 to 122 in 970428a

red = "\033[31m" if sys.platform != "win32" else None
render_diff_range(expected_ranges, expected, colour=red)
sys.stderr.write("Actual:\n")
green = "\033[32m" if sys.platform != "win32" else None
render_diff_range(actual_ranges, actual, colour=green)

Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit 676ed06 into python:master Oct 14, 2024
18 checks passed
@cdce8p cdce8p deleted the update-tox-4.21.2 branch October 14, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants