Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypyc] Replace deprecated _PyDict_GetItemStringWithError #17930

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[mypyc] Replace deprecated _PyDict_GetItemStringWithError #17930

merged 2 commits into from
Oct 16, 2024

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Oct 13, 2024 •
edited
Loading

_PyDict_GetItemStringWithError was deprecated for Python 3.14 in python/cpython#119855.
Use PyDict_GetItemStringRef instead. It was added in 3.13 but is available via pythoncapi_compat.h.

https://docs.python.org/3/c-api/dict.html#c.PyDict_GetItemStringRef

@cdce8p cdce8p added the topic-mypyc mypyc bugs label Oct 13, 2024
hauntsaninja
hauntsaninja reviewed Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this return a strong reference when the old one returned a borrowed reference?

JukkaL
JukkaL approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@JukkaL JukkaL merged commit f63fdb3 into python:master Oct 16, 2024
13 checks passed
@cdce8p cdce8p deleted the replace-deprecated-cpython-function-2 branch October 16, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
topic-mypyc mypyc bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @JukkaL @hauntsaninja