Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubtest: changes for py313 #17261

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

hauntsaninja
Copy link
Collaborator

Technically it feels like we should be able to put the new dunders on type or something, but that wasn't enough to make false positives go away. But also we might not want to do that because it only applies to pure Python types

Technically it feels like we should be able to put the new dunders on
`type` or something, but that wasn't enough to make false positives go
away. But also we might not want to do that because it only applies to
pure Python types
@@ -634,6 +634,10 @@ def strip_prefix(s: str, prefix: str) -> str:
if strip_prefix(stub_arg.variable.name, "__") == runtime_arg.name:
return

nonspecific_names = {"object", "args"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this block?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stubtest attempts to make sure that positional-only arguments have vaguely the same names. This is because when I first wrote stubtest, I found cases of mismatched pos-only args in typeshed. Now having fixed all of those, the value of this check to typeshed is lower, but I'd still like to keep it.

Python 3.13 added text signatures for more callables, but these signatures are autogenerated, see https://github.com/python/cpython/pull/107794/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872R589

So now we no longer check the stub name is vaguely similar if the runtime name is "object"

@hauntsaninja hauntsaninja merged commit 1c83463 into python:master May 18, 2024
13 checks passed
@hauntsaninja hauntsaninja deleted the stubtest-313 branch May 18, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants