Now overloads with ambiguous self are handled properly, refs #11347
#17239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/dtypes/dtypes.py:1173: error: Unused "type: ignore" comment [unused-ignore]
+ pandas/core/nanops.py:519: error: Unused "type: ignore" comment [unused-ignore]
+ pandas/core/nanops.py:534: error: Unused "type: ignore" comment [unused-ignore]
+ pandas/core/nanops.py:575: error: Unused "type: ignore" comment [unused-ignore]
+ pandas/core/nanops.py:590: error: Unused "type: ignore" comment [unused-ignore]
+ pandas/core/nanops.py:1145: error: Unused "type: ignore" comment [unused-ignore]
+ pandas/core/nanops.py:1191: error: Unused "type: ignore" comment [unused-ignore]
+ pandas/core/missing.py:258: error: Unused "type: ignore" comment [unused-ignore]
+ pandas/io/formats/format.py:1573: error: Item "Sequence[float]" of "ndarray[Any, Any] | Sequence[float]" has no attribute "round" [union-attr]
+ pandas/io/formats/format.py:1584: error: No overload variant of "__getitem__" of "Sequence" matches argument type "ndarray[Any, dtype[bool_]]" [call-overload]
+ pandas/io/formats/format.py:1584: note: Possible overload variants:
+ pandas/io/formats/format.py:1584: note: def __getitem__(self, int, /) -> float
+ pandas/io/formats/format.py:1584: note: def __getitem__(self, slice, /) -> Sequence[float]
+ pandas/io/formats/format.py:1586: error: No overload variant of "__getitem__" of "Sequence" matches argument type "ndarray[Any, dtype[bool_]]" [call-overload]
+ pandas/io/formats/format.py:1586: note: Possible overload variants:
+ pandas/io/formats/format.py:1586: note: def __getitem__(self, int, /) -> float
+ pandas/io/formats/format.py:1586: note: def __getitem__(self, slice, /) -> Sequence[float]
tornado (https://github.com/tornadoweb/tornado)
+ tornado/test/iostream_test.py:820: error: Unused "type: ignore" comment [unused-ignore]
pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+ tests/test_timefuncs.py:1213: error: Expression is of type "Any", not "TimestampSeries" [assert-type]
+ tests/test_series.py:1458: error: Expression is of type "Any", not "DataFrame" [assert-type]
+ tests/test_series.py:1464: error: Expression is of type "Any", not "DataFrame" [assert-type]
+ tests/test_series.py:3187: error: Expression is of type "Any", not "Series[type[object]]" [assert-type]
+ tests/test_plotting.py:598: error: Expression is of type "Any", not "Series[Any]" [assert-type]
+ tests/test_plotting.py:602: error: Expression is of type "Any", not "Axes" [assert-type]
+ tests/test_indexes.py:360: error: Expression is of type "IntervalIndex[Any]", not "IntervalIndex[Interval[int]]" [assert-type]
+ tests/test_indexes.py:395: error: Expression is of type "IntervalIndex[Any]", not "IntervalIndex[Interval[int]]" [assert-type]
+ tests/test_indexes.py:403: error: Expression is of type "IntervalIndex[Any]", not "IntervalIndex[Interval[float]]" [assert-type]
+ tests/test_indexes.py:447: error: Expression is of type "IntervalIndex[Any]", not "IntervalIndex[Interval[int]]" [assert-type]
+ tests/test_indexes.py:490: error: Expression is of type "IntervalIndex[Any]", not "IntervalIndex[Interval[int]]" [assert-type]
+ tests/test_indexes.py:506: error: Expression is of type "IntervalIndex[Any]", not "IntervalIndex[Interval[int]]" [assert-type]
+ tests/test_indexes.py:517: error: Expression is of type "IntervalIndex[Any]", not "IntervalIndex[Interval[float]]" [assert-type]
+ tests/test_indexes.py:555: error: Expression is of type "IntervalIndex[Any]", not "IntervalIndex[Interval[int]]" [assert-type]
+ tests/test_indexes.py:610: error: Expression is of type "IntervalIndex[Any]", not "IntervalIndex[Interval[int]]" [assert-type]
mkdocs (https://github.com/mkdocs/mkdocs)
+ mkdocs/tests/config/config_options_tests.py:1679: error: Expression is of type "Any", not "dict[str, dict[Any, Any]]" [assert-type]
|
Member
|
@flaeppe can you please analyze the output? |
sobolevn
reviewed
May 13, 2024
Author
|
Yes, it's just a rebase of your old PR. I've only tried to check the pandas changes, but I'm suspecting that now getting the following changes is incorrect: + pandas/io/formats/format.py:1573: error: Item "Sequence[float]" of "ndarray[Any, Any] | Sequence[float]" has no attribute "round" [union-attr]
+ pandas/io/formats/format.py:1584: error: No overload variant of "__getitem__" of "Sequence" matches argument type "ndarray[Any, dtype[bool_]]" [call-overload]
+ pandas/io/formats/format.py:1584: note: Possible overload variants:
+ pandas/io/formats/format.py:1584: note: def __getitem__(self, int, /) -> float
+ pandas/io/formats/format.py:1584: note: def __getitem__(self, slice, /) -> Sequence[float]
+ pandas/io/formats/format.py:1586: error: No overload variant of "__getitem__" of "Sequence" matches argument type "ndarray[Any, dtype[bool_]]" [call-overload]
+ pandas/io/formats/format.py:1586: note: Possible overload variants:
+ pandas/io/formats/format.py:1586: note: def __getitem__(self, int, /) -> float
+ pandas/io/formats/format.py:1586: note: def __getitem__(self, slice, /) -> Sequence[float]It's within the following function and stems from this line: https://github.com/pandas-dev/pandas/blob/283a2dcb2f91db3452a9d2ee299632a109b224f4/pandas/io/formats/format.py#L1561 I haven't been able to find a reproducible case but essentially what is happening here is that there's a narrowing of a union, via a helper similar to something like this: def helper(val: Any) -> np.ndarray: ...
percentiles: np.ndarray | Sequence[float]
percentiles = helper(percentiles)
reveal_type(percentiles) # Revealed type is "np.ndarray | Sequence[float]"There's a couple of Here's a related issue and comments: #2008 (comment) |
Author
|
Correct me if I'm wrong, but if I'm reading the comments in #2008 and the Always narrow types section in #16472 (comment) correctly I don't think issue mentioned in the above comment #17239 (comment) is caused by the changes here. |
Contributor
|
Haven't looked into the PR yet, but I'm wondering if this now complies with the recently added chapter in the spec (see python/typing#1667) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self-annotated methods #11347selfare handled properly #11366This is simply a rebase of #11366 (See #11366 (comment) CC @sobolevn), I kept the changes intact.