Fix 'WriteToConn' object has no attribute 'flush'
#16801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This default isn't used anywhere in the codebase.
meshy
force-pushed
the
fix-WriteToConn-type
branch
2 times, most recently
from
7229960
to
3241a72
Compare
This comment has been minimized.
This comment has been minimized.
meshy
commented
Jan 20, 2024
meshy
force-pushed
the
fix-WriteToConn-type
branch
from
3241a72
to
aee0c2a
Compare
This class replaced stdout and stderr to capture output, but caused issues because it didn't implement the full API of sys.stdout and sys.stderr. By fully stubbing the TextIO API we prevent issues with other code which uses more of the API than we had previously accounted for. Fixes python#16678
meshy
force-pushed
the
fix-WriteToConn-type
branch
from
b939bb3
to
a405475
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Jan 30, 2024
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteToConnreplaces stdout and stderr to capture output, but causes issues because it doesn't implement theTextIOAPI (as expected ofsys.stdoutandsys.stderr).By stubbing the rest of the
TextIOAPI we prevent issues with other code which uses more of the API than we had previously accounted for.Fixes #16678