Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mypyc] Fixes to float to int conversion #14936

Merged
merged 3 commits into from
Mar 22, 2023
Merged

[mypyc] Fixes to float to int conversion #14936

merged 3 commits into from
Mar 22, 2023

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Mar 22, 2023

Fix undefined behavior due to converting a negative float to an unsigned integer type. Fix edge cases on 32-bit platforms.

The first issue was caught by the testI32BasicOps test case, but only in some configurations, it looks like.

Fix undefined behavior when converting a negative float to
an unsigned integer type. Fix edge cases on 32-bit platforms.

The first issue was caught by the testI32BasicOps test case, but only
in some configurations.
@JukkaL
Copy link
Collaborator Author

JukkaL commented Mar 22, 2023

I'm hoping that this will fix wheel builds: https://github.com/mypyc/mypy_mypyc-wheels/actions

@JukkaL JukkaL merged commit aa2679b into master Mar 22, 2023
@JukkaL JukkaL deleted the fix-wheels branch March 22, 2023 17:35
@JukkaL JukkaL mentioned this pull request Mar 23, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants