Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading TODO comment in testIterableUnpackingWithGetAttr #14894

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Fix misleading TODO comment in testIterableUnpackingWithGetAttr #14894

merged 3 commits into from
Mar 13, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Mar 13, 2023 •
edited
Loading

Follow-up to #14893

See #14892 for more discussion

@AlexWaygood AlexWaygood requested a review from JukkaL March 13, 2023 16:12
JelleZijlstra
JelleZijlstra approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it again and I don't see any more typos.

@JelleZijlstra JelleZijlstra merged commit 486a51b into python:master Mar 13, 2023
@AlexWaygood AlexWaygood deleted the patch-1 branch March 13, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @JelleZijlstra @JukkaL