Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use literal-required error code for TypedDicts #14621

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

ilevkivskyi
Copy link
Member

Ref #7178

This code is used for some TypedDict errors, but misc was used for others. I make it more consistent. Also this code looks undocumented, so I add some basic docs.

@github-actions

This comment has been minimized.

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the clean mypy_primer output, this doesn't seem to be a major backward compatibility issue.

------------------------------------------------------------

There are some places where only a (string) literal value is expected for
the purposes of statis type checking, for example a ``TypedDict`` key, or
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: statis

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@ilevkivskyi ilevkivskyi merged commit 35b2926 into python:master Feb 7, 2023
@ilevkivskyi ilevkivskyi deleted the literal-code branch February 7, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants