Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive on generic base class with six #14478

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Fix false positive on generic base class with six #14478

merged 1 commit into from
Jan 20, 2023

Conversation

ilevkivskyi
Copy link
Member

Fixes #14475

The fix is straightforward. We need to use the "guarded accept" at this stage, similar to e.g. clean_up_bases_and_infer_type_variables().

@ilevkivskyi ilevkivskyi mentioned this pull request Jan 20, 2023
Closed
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JukkaL
JukkaL approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@JukkaL JukkaL merged commit 9a8c171 into python:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unbound type variable false positive with six.with_metaclass
2 participants
@ilevkivskyi @JukkaL